frontend: Fix exit from tray context menu#13621
Open
zorbathut wants to merge 1 commit into
Open
Conversation
Due to unintuitive Qt behavior, right-clicking tray context menu and choosing "exit" works only if the main window has already been displayed. Work around by sending the close event manually when necessary. Fixes obsproject#13494.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to unintuitive Qt behavior in Wayland, right-clicking tray context menu and choosing "exit" works only if the main window has already been displayed.
Work around by sending the close event manually when necessary.
Fixes #13494.
Motivation and Context
--minimize-to-tray allows starting in tray-minimized form. On Wayland, this prevents you from using the right-click menu to close it.
How Has This Been Tested?
Opened with --minimize-to-tray, verified I could close it. Opened without that, verified I could still close it. Opened with it and opened the window manually, verified I could still close it.
Tested on Manjaro Linux, Wayland, KDE desktop.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: